Skip to content

dirname: add fuzzer to test GNU compatibility #10289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sylvestre wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dirname: add fuzzer to test GNU compatibility #10289

sylvestre wants to merge 2 commits into from
+231 −2

Conversation

@sylvestre
Copy link
Contributor

@sylvestre sylvestre commented Jan 17, 2026

No description provided.

@sylvestre
Copy link
Contributor Author

sylvestre commented Jan 17, 2026

it should not identify any crash
it is really for compat
should pass after #8936 is merged

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 17, 2026 •
edited
Loading

Merging this PR will degrade performance by 3.26%

❌ 1 regressed benchmark
✅ 281 untouched benchmarks
⏩ 38 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Memory dd_copy_partial 129.1 KB 133.5 KB -3.26%

Comparing sylvestre:dirname-fuzz (4712557) with main (2122c52)2

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (4e7fa9f) during the generation of this report, so 2122c52 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sylvestre
Copy link
Contributor Author

sylvestre commented Jan 17, 2026

nice, it fails as expected

@sylvestre sylvestre force-pushed the dirname-fuzz branch 2 times, most recently from 8253967 to bf7ca75 Compare January 17, 2026 16:43
@github-actions
Copy link

github-actions bot commented Jan 17, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/follow-name. tests/tail/follow-name is passing on 'main'. Maybe you have to rebase?

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 18, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/follow-name. tests/tail/follow-name is passing on 'main'. Maybe you have to rebase?

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

@sylvestre
dirname: add fuzzer to test GNU compatibility
7c5383d
@sylvestre
fuzzing: fix should_pass evaluation in CI workflow
4712557 
Fixed two bugs in the fuzzing workflow where matrix.test-target.name.should_pass
was used instead of matrix.test-target.should_pass. This caused continue-on-error
to always be true, making CI jobs pass even when fuzzers correctly detected
incompatibilities.
@sylvestre
Copy link
Contributor Author

sylvestre commented Jan 18, 2026

#10335 disabled one of the fuzzer that failed

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sylvestre